Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

ref(nextjs): Set more specific event mechanisms #17543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 8 commits into develop from lms/ref-nextjs-mechanism
Sep 12, 2025
Merged

Conversation

Copy link
Member

@Lms24 Lms24 commented Sep 5, 2025 •
edited
Loading

exception mechanism now follows the trace origin naming scheme.
Also added a couple of test assertions for tests expecting errors.

closes #17258

seer-by-sentry[bot] reacted with hooray emoji
@Lms24 Lms24 self-assigned this Sep 5, 2025
@Lms24 Lms24 force-pushed the lms/ref-nextjs-mechanism branch from 4b4059e to 8c80a53 Compare September 8, 2025 08:36
@Lms24 Lms24 marked this pull request as ready for review September 8, 2025 08:36
@Lms24 Lms24 requested review from chargome and RulaKhaled and removed request for chargome September 8, 2025 08:36
@Lms24 Lms24 force-pushed the lms/ref-nextjs-mechanism branch from 8c80a53 to 50924ca Compare September 10, 2025 16:17
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 11, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,882 - 9,405 -6%
GET With Sentry 1,203 14% 1,244 -3%
GET With Sentry (error only) 5,947 67% 6,082 -2%
POST Baseline 1,189 - 1,194 -0%
POST With Sentry 466 39% 496 -6%
POST With Sentry (error only) 1,034 87% 1,061 -3%
MYSQL Baseline 3,249 - 3,356 -3%
MYSQL With Sentry 375 12% 410 -9%
MYSQL With Sentry (error only) 2,664 82% 2,703 -1%

View base workflow run

Copy link
Member

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! one quick comment though

@@ -5,6 +5,7 @@ test('should report healthy sessions', async ({ page }) => {
test.skip(process.env.TEST_ENV === 'development', 'test is flakey in dev mode');

const sessionPromise = waitForSession('nextjs-13', session => {
console.log('session', session);
Copy link
Member

@RulaKhaled RulaKhaled Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah can we get rid of this please

Lms24 reacted with thumbs up emoji
@Lms24 Lms24 force-pushed the lms/ref-nextjs-mechanism branch from e71da78 to f5ae12f Compare September 12, 2025 14:23
@Lms24 Lms24 merged commit 6e11be9 into develop Sep 12, 2025
50 checks passed
@Lms24 Lms24 deleted the lms/ref-nextjs-mechanism branch September 12, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@RulaKhaled RulaKhaled RulaKhaled approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust mechanism in nextjs SDK
2 participants

AltStyle によって変換されたページ (->オリジナル) /